unnecessary_operation: don't suggest autofixes on composite types with fields of uncertain types
#15460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
this makes the test case `unfixable`, so move it to a separate file
ada4a
force-pushed
the
unnecessary-operation-uncertain-exprs
branch
from
5477205 to
dff9f73
Compare
ada4a
commented
Aug 11, 2025
| if let StmtKind::Semi(expr) = stmt.kind | ||
| && !stmt.span.in_external_macro(cx.sess().source_map()) | ||
| && let ctxt = stmt.span.ctxt() | ||
| && expr.span.ctxt() == ctxt | ||
| && let Some(reduced) = reduce_expression(cx, expr) | ||
| && let Some(reduced) = reduce_expression(cx, expr, &mut applicability) | ||
| && reduced.iter().all(|e| e.span.ctxt() == ctxt) |
There was a problem hiding this comment.
Kind of off-topic: I was forced to use the more verbose Vec::new() syntax in all the tests because, when I used vec![], this check would prevent the lint from firing. That doesn't sound quite right to me?
ada4a
changed the title
unnecessary_operation: don't lint on composite types with fields of uncertain typesunnecessary_operation: don't suggest autofixes on composite types with fields of uncertain types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15381
changelog: [
unnecessary_operation]: reduce applicability on exprs with uncertain types