Skip to content

Fix match_ref_pats FP on match scrutinee of never type #15474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

Fix match_ref_pats FP on match scrutinee of never type #15474

merged 1 commit into from
Aug 14, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Aug 13, 2025 •
edited
Loading

Closes #15378

changelog: [match_ref_pats] fix FP on match scrutinee of never type

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2025
y21
y21 reviewed Aug 13, 2025
View reviewed changes
@profetia profetia changed the title Fix match_ref_pats FP on unimplement!() in match scrutinee Fix match_ref_pats FP on match scrutinee of never type Aug 14, 2025
y21
y21 approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@y21 y21 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into rust-lang:master with commit 871df56 Aug 14, 2025
14 of 15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 14, 2025
@profetia
Copy link
Contributor Author

@y21 Thank you! And if you have time, please take a look at #15101, which has been stale for too long

@profetia profetia deleted the issue15378 branch September 12, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

match_ref_pats matching on macros like unimplemented there is nothing that can be dereferenced

3 participants

@profetia @rustbot @y21