Rewrite bit mask lints #15587
Open
Rewrite bit mask lints #15587
+1,583
−342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
| LL | let _ = x & (0b0100 | 0b0010) == (0b0111 ^ 0b1000); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | | ||
| = note: `0x6` is missing bits contained in the compared constant `0xf` |
There was a problem hiding this comment.
Maybe you should add extra notes when the constant is not present as a literal, for example one pointing to 0b0100 | 0b0010 saying "this evaluates to 0x6, ditto for 0xf.
|
☔ The latest upstream changes (possibly f3c020c) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper functions/types could be pulled into
clippy_utils. I'm going to go through and sort that crate out in a separate PR first rather than add to it now.changelog: [
ineffective_bit_masks]: Lint xor expressions