Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 2, 2025

Fixes #15602

This implements the "make the reconstruction more robust" approach, because the other one turned out to be somewhat complicated -- one would need to find the exact place the temporary was used in, and suggest replacing exactly that.

Based on #15598, but mostly for easier rebasing later.

changelog: [significant_drop_tightening]: handle complex let-statements

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 2, 2025
@ada4a
Copy link
Contributor Author

ada4a commented Sep 2, 2025

r? clippy

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2025

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@rustbot rustbot assigned llogiq and unassigned Alexendoo Sep 2, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Lintcheck changes for 519964e

Lint Added Removed Changed
clippy::significant_drop_tightening 0 0 54

This comment will be updated if you push new changes

@ada4a ada4a force-pushed the significant_drop_tightening-mut-idents branch from 210ffb7 to 5b61106 Compare September 2, 2025 13:55
@rustbot

This comment has been minimized.

@ada4a ada4a force-pushed the significant_drop_tightening-mut-idents branch from 5b61106 to 519964e Compare October 11, 2025 08:31
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

☔ The latest upstream changes (possibly eee8ef8) made this pull request unmergeable. Please resolve the merge conflicts.

@llogiq
Copy link
Contributor

llogiq commented Oct 15, 2025

I'm a bit unsure about those two suggestions. Is there a way we can do that without it becoming unrustfixable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

significant_drop_tightening suggests incomplete binding

4 participants