Use expect for lint warnings

[nickdrozd]

changelog:none

[rustbot]

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in clippy_lints/src/doc

cc @notriddle

[y21]

This does seem like a solid improvement (especially since this allows removing some #[allow]s), though one comment on enabling the lint on the codebase. Apart from that lgtm

View changes since this review

[nickdrozd]

This is ready to go.

[samueltardieu]

Since the only change requested by @y21 before merging has been done, I'll merge this to avoid having to rebase frequently.

[samueltardieu]

Dogfood needs to be fixed due to recent changes in const values evaluation in Clippy.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[nickdrozd]

@rustbot ready

[nickdrozd]

Fixed the constant thing. Also changed another allow that had snuck in.