Skip to content

fix(semicolon_inside_block): don't lint if block is in parens #15626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

fix(semicolon_inside_block): don't lint if block is in parens #15626

merged 1 commit into from
Sep 9, 2025
+50 −6

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 7, 2025

Decided not to lint in this case after all, as per #15391 (comment)

Supersedes #15421, fixes #15380, fixes #15389

changelog: [semicolon_inside_block]: don't lint if block is in parens

@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 7, 2025
samueltardieu
samueltardieu requested changes Sep 8, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except an extra test I'd like to see added.

r? samueltardieu
@rustbot author

View changes since this review

@rustbot rustbot assigned samueltardieu and unassigned y21 Sep 8, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Sep 8, 2025
@ada4a ada4a force-pushed the semicolon-inside-block branch from 1130cba to 36c2c0a Compare September 8, 2025 19:24
@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author

ada4a commented Sep 8, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 8, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Sep 9, 2025
@samueltardieu
Copy link
Member

Thanks!

Merged via the queue into rust-lang:master with commit 49e2f37 Sep 9, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 9, 2025
@ada4a ada4a deleted the semicolon-inside-block branch September 9, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

semicolon_inside_block creates what looks like a function call semicolon-inside-block removes parens breaking code

4 participants

@ada4a @rustbot @samueltardieu @y21