-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add new GUI testsuite #15634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add new GUI testsuite #15634
Conversation
|
aab5162
to
a7cb119
Compare
CI passed! \o/ |
If they're on holiday let's pick someone else then. :) |
I'd like to help, but I'm probably the worst person to select here as I really abhor everything related to GUI. |
a7cb119
to
53cd032
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Applied suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how if browser-ui-test isn't installed, the test is skipped, could we also do something like that on npm?
Sure! |
53cd032
to
c49dd74
Compare
22997d2
to
1e4d6ff
Compare
Fixed dogfood as well. ^^' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comment before asking the team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question before askign the team for approval, does goml have a system to output on error for each test?
Some reviewers really don't like GUI-related things, so having a custom message be outputed if a specific assert fails would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error output looks like this: https://github.com/GuillaumeGomez/browser-UI-test/blob/master/tests/ui/assert-css-color.output, so normally you have all needed information (ie, file and line and even compared values).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll cc @rust-lang/clippy and maybe cc @rust-lang/clippy-contributors if they have feedback. While sadly having it be screenshot-based would load a huge dependency into our tree, the error messages are rich enough that contributors will be able to fix the issues themselves.
1e4d6ff
to
a5a81fb
Compare
Applied suggestions. |
To summarize my position from the zulip thread:
FWIW this is the large dependency, |
As discussed on zulip, here is the very start of adding this new GUI testsuite.
r? @flip1995
changelog: Add new GUI testsuite