New lint - same_length_and_capacity
#15656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for d6a455e
This comment will be updated if you push new changes |
rustbot
added
S-blocked
|
Oops, I understand why CI failed. I'll take care of that. |
samueltardieu
added
S-waiting-on-author
km274
force-pushed
the
from_raw_parts_same_len_and_cap
branch
from
10aca0a to
2a4a572
Compare
This comment has been minimized.
This comment has been minimized.
|
@rustbot ready |
rustbot
added
S-waiting-on-review
km274
force-pushed
the
from_raw_parts_same_len_and_cap
branch
3 times, most recently
from
de87dd6 to
b3cbb63
Compare
This comment has been minimized.
This comment has been minimized.
… expression is used for the length and the capacity
km274
force-pushed
the
from_raw_parts_same_len_and_cap
branch
from
b3cbb63 to
d6a455e
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5955
I understand that there's a feature freeze right now. I had started working on this before I was aware of the feature freeze. I don't mind waiting as long as I need to for feedback.
changelog: [
same_length_and_capacity]: adds a new lint that checks for usages offrom_raw_partswhere the same expression is passed for the length and the capacitySummary Notes
Managed by
@rustbot—see help for details