Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 11, 2025

Fixes #15657

changelog: [len_zero]: fix ICE when fn len has a return type without generic type params

r? @y21

Results in an ICE if the output type has no generic type params
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2025
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! :)

View changes since this review

@y21 y21 added this pull request to the merge queue Sep 11, 2025
Merged via the queue into rust-lang:master with commit 467efe0 Sep 11, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2025
@ada4a ada4a deleted the len_zero-ice branch September 11, 2025 20:08
@y21
Copy link
Member

y21 commented Sep 16, 2025

I believe this fix wouldn't make it into the same release cycle as the commit that introduced it, and the repro seems not too uncommon for people to hit, so let's also: @rustbot label +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 16, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Sep 16, 2025

It is for 0.90? In this case, this might not make it, as the tarball must be ready already. It would be a stable merge in case there is a point release.

Ping @flip1995

Edit: the bug report was for 0.91, so on the contrary we may have time.
Edit 2: yes, the bug was introduced one month ago, so it will be in 0.91 only

@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint len_zero panicked: index out of bounds: the len is 0 but the index is 0

5 participants