Add large-error-ignored config-knob
#15697
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ada4a
reviewed
Sep 20, 2025
Comment on lines
+114
to
119
| if let ty::Adt(adt, _) = err_ty.kind() | ||
| && large_err_ignored.contains(&adt.did()) | ||
| { | ||
| return; | ||
| } | ||
| if let ty::Adt(adt, subst) = err_ty.kind() |
There was a problem hiding this comment.
Maybe integrate this check into the let-chain?
if let ty::Adt(adt, subst) = err_ty.kind()
&& !large_err_ignored.contains(&adt.did())
&& /* rest of the let-chain.. */There was a problem hiding this comment.
nitpicked about that, but that would complicate the else-clause
There was a problem hiding this comment.
Ah, I see what you mean. Then maybe put this check inside the then-block?
This doesn't really matter of course – it's just that it looks a bit strange to me to check for err_ty being an ADT twice
There was a problem hiding this comment.
I agree, yet all variants come down to some duplication, so I'd rather leave it as it
|
r? clippy |
|
☔ The latest upstream changes (possibly a8d1258) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15404
changelog: [
result_large_err]: Addlarge_error_ignoredconfiguration