Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 23, 2025

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, didn't we merge a lint recently that should've caught that 🤔

View changes since this review

@flip1995 flip1995 enabled auto-merge September 23, 2025 15:03
@flip1995 flip1995 added this pull request to the merge queue Sep 23, 2025
@ada4a
Copy link
Contributor Author

ada4a commented Sep 23, 2025

Given that even the formatting in the code block turned out to be wrong, I don't think that rustfmt/clippy are run on the code blocks?

@y21 y21 disabled auto-merge September 23, 2025 15:10
@y21
Copy link
Member

y21 commented Sep 23, 2025

(Oops, sorry for disabling auto-merge queue, I thought the button said "view review comments" instead of "disable merge queue" and instinctively clicked it without reading. It won't let me enable it again but I assume it still goes through)

Merged via the queue into rust-lang:master with commit 9bcc8a4 Sep 23, 2025
8 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
@ada4a ada4a deleted the trait_checking branch September 23, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants