Skip to content

Fix let_unit_value suggests wrongly for field init shorthand #15791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

Fix let_unit_value suggests wrongly for field init shorthand #15791

merged 1 commit into from
Oct 3, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Sep 30, 2025 •
edited by rustbot
Loading

Closes #15789

changelog: [let_unit_value] fix wrong suggestions for field init shorthand

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2025 •
edited
Loading

Lintcheck changes for 089fbd3

Lint Added Removed Changed
clippy::let_unit_value 0 0 3

This comment will be updated if you push new changes

ada4a
ada4a suggested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@ada4a ada4a left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this! Just a small documentation suggestion

View changes since this review

blyxyas
blyxyas approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ great contribution with a really elegant approach to solving the problem. I also liked how to gave room for further change in the future.

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Oct 3, 2025
Merged via the queue into rust-lang:master with commit 8229701 Oct 3, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

+1 more reviewer

@ada4a ada4a ada4a requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

let_unit_value mangles field init shorthand syntax

4 participants

@profetia @rustbot @ada4a @blyxyas