New internal lint: unusual_names
#15794
Open
+135
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
samueltardieu
force-pushed
the
features/unusual-names
branch
from
bc0b47c to
188849d
Compare
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
features/unusual-names
branch
from
188849d to
469557a
Compare
|
Seems reasonable. Will wait a bit if anyone on the team has anything to add. cc @rust-lang/clippy |
|
Sounds fine to me, feels like something we could make into a [allowed-names]
"rustc_errors::Applicability" = ["app", "applicability"]
"rustc_middle::ty::TyCtxt" = "tcx"
# etc |
|
I thought about this and as long as it is an internal lint only we can edit the source as easily as we would edit the configuration file. But if we make it a general lint, it would be a good idea to make it configurable of course. |
This lint aims at detecting unusual names used in Clippy source code, such as `appl` or `application` for a `rustc_errors::Applicability` variable, instead of `app` and `applicability` which are commonly used throughout Clippy. This helps maintaining the consistency of the Clippy source code.
samueltardieu
force-pushed
the
features/unusual-names
branch
from
469557a to
4c32a55
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint aims at detecting unusual names used in Clippy source code, such as
applorapplicationfor arustc_errors::Applicabilityvariable, instead ofappandapplicabilitywhich are commonly used throughout Clippy.This helps maintaining the consistency of the Clippy source code.
It is currently implemented for:
Applicability:apporapplicabilityEarlyContext/LateContext:cxTyCtxt:tcxchangelog: none