feat(lints): add unsigned_subtraction_gt_zero lint for comparisons against zero after subtraction
#15820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
|
Lintcheck changes for 3c7f816
This comment will be updated if you push new changes |
…against zero after subtraction
AMS21
force-pushed
the
unsigned_subtraction_gt_zero
branch
from
59419d1 to
3c7f816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: new lint: [
unsigned_subtraction_gt_zero] Lints comparisons of an unsigned integer subtraction against zero, like(a - b) > 0.If
a < b,a - bwill panic in debug builds and wrap in release builds, making the effectively behave likea != b. This is likely unintended;a > bis clearer avoids potential panics and wraparound.Fixes #588