Skip to content

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Oct 8, 2025

changelog: [expl_impl_clone_on_copy]: honor allow/expect attributes on both the type declaration and the impl

Fixes #15842

r? @blyxyas

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 8, 2025
Copy link

github-actions bot commented Oct 8, 2025

Lintcheck changes for 69bd890

Lint Added Removed Changed
clippy::expl_impl_clone_on_copy 0 0 326

This comment will be updated if you push new changes

@samueltardieu
Copy link
Member Author

samueltardieu commented Oct 8, 2025

The lintcheck changes are due to the fact that I removed the repeated span of the help message (it quoted the same excerpt as the lint itself, which was redundant).

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

View changes since this review

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Oct 9, 2025
Merged via the queue into rust-lang:master with commit 57913b4 Oct 9, 2025
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 9, 2025
@samueltardieu samueltardieu deleted the fixes/15842 branch October 9, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow(clippy::expl_impl_clone_on_copy) stopped working

3 participants