refactor(match_like_matches_macro): disentangle the if-let and match cases #15854
+140
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's now just the first arm
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
simplify-match_like_matches
branch
from
0f9bd65 to
6ef8f58
Compare
ada4a
force-pushed
the
simplify-match_like_matches
branch
from
6ef8f58 to
dd7f605
Compare
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
simplify-match_like_matches
branch
from
2ee4090 to
675b033
Compare
ada4a
force-pushed
the
simplify-match_like_matches
branch
from
675b033 to
0535908
Compare
|
r? llogiq Assigning back. I sadly don't have time to review PRs atm... Sorry :( |
|
Nice! Thank you. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #clippy > `match_like_matches_macro` does the work of`match_same_arms`
Sorry for the large number of commits -- I could've gotten away just three ("clean-up", and one for each inlining of
find_matches_suggand subsequent simplifications), but I found the diff of that quite difficult to understand.changelog: none