Skip to content

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Oct 10, 2025

Resolves #15780.

I didn't get any feedback on that issue. So I hope it is okay that I charged ahead and addressed it.

changelog: Allow explicit_write in tests

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@smoelius smoelius force-pushed the allow-explicit-write-in-tests branch from 720f1f5 to 1eb9a09 Compare October 11, 2025 10:29
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@smoelius smoelius force-pushed the allow-explicit-write-in-tests branch from 1eb9a09 to 1bd8cad Compare October 14, 2025 15:53
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Since this is a complexity lint it shouldn't be suggesting something that changes behaviour.

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Oct 15, 2025
Merged via the queue into rust-lang:master with commit d230acd Oct 15, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable explicit_write in test code?

4 participants