{option,result}_map_unit_fn: fix and clean-up tests, make suggestions multiline
#15871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
option_map_unit_fn
branch
from
0d05b6c to
a981893
Compare
ada4a
changed the title
option_map_unit_fn: fix and clean-up tests, make suggestions multiline{option,result}_map_unit_fn: fix and clean-up tests, make suggestions multiline
Jarcho
requested changes
Oct 12, 2025
| | | ||
| = note: `-D clippy::option-map-unit-fn` implied by `-D warnings` | ||
| = help: to override `-D warnings` add `#[allow(clippy::option_map_unit_fn)]` | ||
| help: try |
There was a problem hiding this comment.
The help message needs to be changed to something useful (e.g. 'use an if let instead'). "try" is only used with inline suggestions because longer messages looked bad.
rustbot
added
S-waiting-on-author
The errors were unrelated to the lint...
ada4a
force-pushed
the
option_map_unit_fn
branch
from
a981893 to
3b7b05c
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
ada4a
force-pushed
the
option_map_unit_fn
branch
from
3b7b05c to
71d17de
Compare
- make them `verbose` -- the ones spanning multiple lines were especially egregious - give a more descriptive help message
ada4a
force-pushed
the
option_map_unit_fn
branch
from
71d17de to
98db098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none