Skip to content

Conversation

@Wassasin
Copy link

changelog: [unused_async_trait_impl]: added lint that checks for trait impl functions that are unnecessarily async. By rewriting them to return a core::future::ready an unnecessary coroutine is prevented.

In an embedded context having many trivial async blocks potentially hurts code size significantly. This lint enables projects to quickly find the cases that this applies to.

Unsure about if this is the right method to replace the relevant code spans. Any feedback is very welcome.

@Wassasin Wassasin force-pushed the unused_async_trait_impl branch 2 times, most recently from 07c84ff to 29282db Compare December 15, 2025 15:56
@rustbot

This comment has been minimized.

@Wassasin Wassasin marked this pull request as ready for review January 5, 2026 10:16
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 5, 2026
@Wassasin Wassasin force-pushed the unused_async_trait_impl branch from 265ec66 to cf7dc77 Compare January 5, 2026 10:18
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants