Skip to content

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Feb 24, 2019

This moves the lint building functions from utils/mod.rs to their own
utils/diagnostics.rs file. Also adds documentation for three of them.

This moves the lint building functions from `utils/mod.rs` to their own
`utils/diagnostics.rs` file. Also adds documentation for three of them.
@flip1995
Copy link
Member

flip1995 commented Feb 24, 2019

needs a rebase once #3790 is merged. r=me after rebase.

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Feb 24, 2019
@flip1995
Copy link
Member

Oh wait this should go through without a rebase, oops. Let's queue this.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 24, 2019

📌 Commit 7d883cd has been approved by flip1995

bors added a commit that referenced this pull request Feb 24, 2019
Extract diagnostics module and document some functions

This moves the lint building functions from `utils/mod.rs` to their own
`utils/diagnostics.rs` file. Also adds documentation for three of them.
@bors
Copy link
Contributor

bors commented Feb 24, 2019

⌛ Testing commit 7d883cd with merge 5833e4d...

@bors
Copy link
Contributor

bors commented Feb 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 5833e4d to master...

@bors bors merged commit 7d883cd into rust-lang:master Feb 24, 2019
@phansch phansch deleted the refactor/extract_module branch February 24, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants