Improve non ascii literal #4119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
requested changes
May 20, 2019
There was a problem hiding this comment.
Thanks for the contribution! Especially for the extra work! ❤️
When you change something on the lint emitting code, you also have to update the *.stderr reference files. How to do this is documented here. (You basically have to run tests/ui/update-all-references.sh after running cargo uitest)
There are two more occurences of span_help_and_lint in the code. It would be great if you could give those the same treatment.
flip1995
approved these changes
May 20, 2019
|
The *.stderr file is missing the suggestions. I think this is another case of #3582 (comment) and #3913, so nothing you can do about. |
flip1995
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 36c8aab has been approved by |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
May 27, 2019
Improve non ascii literal This PR improves the example of the [non_ascii_literal](https://rust-lang.github.io/rust-clippy/master/index.html#non_ascii_literal) lint. It also makes it auto-fixable. Please review. This is my first PR to this project. (Thanks @flip1995 for the help :) changelog: none fixes rust-lang#4117
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the example of the non_ascii_literal lint.
It also makes it auto-fixable.
Please review. This is my first PR to this project.
(Thanks @flip1995 for the help :)
changelog: none
fixes #4117