Skip to content

Do not early exit if cargo clippy returns non-zero status code #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Do not early exit if cargo clippy returns non-zero status code #4720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53f14ab
Early exit in integration tests
tesuji Oct 23, 2019
84da79e
build: strip before caching in .cargo/bin
tesuji Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ cache:
before_cache:
- cargo install -Z install-upgrade cargo-cache --debug
- cargo cache --autoclean
- find $HOME/.cargo/bin/ ! -type d -exec strip {} \;

env:
global:
Expand Down
15 changes: 10 additions & 5 deletions ci/integration-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,21 @@ cargo install --force --debug --path .
echo "Running integration test for crate ${INTEGRATION}"

git clone --depth=1 "https://github.com/${INTEGRATION}.git" checkout
cd checkout || exit 1
cd checkout

# run clippy on a project, try to be verbose and trigger as many warnings as possible for greater coverage
# run clippy on a project, try to be verbose and trigger as many warnings
# as possible for greater coverage
RUST_BACKTRACE=full \
cargo clippy \
--all-targets \
--all-features \
-- --cap-lints warn -W clippy::pedantic -W clippy::nursery \
2>& 1 \
| tee clippy_output
-- \
--cap-lints warn \
-W clippy::pedantic \
-W clippy::nursery \
> clippy_output 2>&1 || true

cat clippy_output

if grep -q "internal compiler error\|query stack during panic\|E0463" clippy_output; then
exit 1
Expand Down