update installation methods to use TLS v1.2 #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbtcollins Do you mind taking a look? |
rbtcollins
approved these changes
Jun 18, 2023
rylev
approved these changes
Jun 19, 2023
3 tasks
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update other installation methods for Unix compatible OSes to use TLS v1.2 consistently with https://github.com/rust-lang/rustup/blob/843459f893091f89b2dd5c7a977da1b3eb28df1b/www/index.html#L31
See rust-lang/www.rust-lang.org#1823 (comment) for more information on why it is useful. TLDR: this allows to avoid MITM attacks when users are installing Rust using
rustup-init.sh.See similar PR to rustup repo: rust-lang/rustup#3385
Closes #684