Skip to content

add "Team Roles" section to "Issue Triage" page #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

add "Team Roles" section to "Issue Triage" page #843

merged 1 commit into from
May 7, 2025
+31 −1

Conversation

@lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented May 2, 2025 •
edited by rustbot
Loading

@rustbot
Copy link
Collaborator

rustbot commented May 2, 2025

r? @Dylan-DPC

rustbot has assigned @Dylan-DPC.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2025
jieyouxu
jieyouxu reviewed May 2, 2025
View reviewed changes
jieyouxu
jieyouxu approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two nits

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2025
@jieyouxu
Copy link
Member

jieyouxu commented May 7, 2025

Also, can you squash the commits after addressing the nits?

@jieyouxu jieyouxu self-assigned this May 7, 2025
jieyouxu
jieyouxu approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jieyouxu jieyouxu merged commit 7ef2d73 into rust-lang:master May 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

@Dylan-DPC Dylan-DPC

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lolbinarycat @rustbot @jieyouxu @Dylan-DPC