Skip to content

Learn from PR builds too #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Learn from PR builds too #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bin/server/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,11 @@ impl Worker {
if !outcome.is_passed() {
self.report_failed(build_id, build.as_ref())?;
}
if build.pr_number().is_none() && build.branch_name() == "auto" {
if build.pr_number().is_some() || build.branch_name() == "auto" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update this for new-bors as well (cc @Kobzol) and we might want to include try jobs I guess?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try jobs are a subset of auto jobs, so not sure if it adds a lot of additional value. For new bors the branch name should be probably automation/bors/auto, but we haven't decided it yet. Created #90 to track this.

info!("learning from the log");
self.learn(build.as_ref())?;
} else {
info!("did not learn as it's not an auto build");
info!("did not learn as it's not an auto build or a PR build");
}

Ok(ProcessOutcome::Continue)
Expand Down
Loading