Enhance go-to-position for the simple and Monaco editors#1136
Merged
shepmaster merged 5 commits intomainfrom Feb 10, 2025
Merged
Enhance go-to-position for the simple and Monaco editors#1136shepmaster merged 5 commits intomainfrom
shepmaster merged 5 commits intomainfrom
Conversation
We already use object identity for this prop with Ace (and Redux helps us keep it stable) and this allows a person to click the link a second time and get the code re-selected. Since the prop doesn't change value, the second click does nothing with a value-based test.
Off-by-one errors are the worst.
shepmaster
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.