Merged
Conversation
The link-list lines had ./2026/highlights.md instead of ./highlights.md — these are relative to the README's own directory, so the 2026/ prefix was wrong.
Instead of hardcoding #### for highlight goal sections, search backwards from the directive for the most recent heading and generate sub-headings one level deeper. This produces correct heading hierarchies regardless of where the directive appears.
- Resolve link-list paths via Path::join against book_dir instead of regex-extracting the stem, so any relative path works. - Track current heading level while processing the index and pass it to inline_rendered_file, which computes the delta between the insertion context and the file's top heading. Headings are shifted by that delta instead of always bumping +1.
Rewrite the rfc_command.md chapter from a 4-line stub into a full explanation of the RFC generation pipeline: usage, high-level overview, detailed step-by-step walkthrough, and backward compatibility notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the RFC generation--
We now start from the
NNNN/README.md, walk down the page, and expand* [Chapter](./chapter.md)to be captured inline. When we do that, we adjust the heading levels to fit it all together.Rendered