Apply suggestions from code review

Author: TimTheBig

library/alloc/src/bstr.rs

@@ -245,10 +245,7 @@ impl From<ByteString> for Vec<u8> {
 
 #[unstable(feature = "bstr", issue = "134915")]
 impl<'a> From<&'a ByteStr> for ByteString {
-    /// Convert the `ByteStr` to a `Vec` then wrap it in a `ByteString`.
-    ///
-    /// ## Cost
-    /// Allocates a new `Vec`
+    /// Allocates a `ByteString` containing the bytes of `ByteStr`.
     #[inline]
     fn from(s: &'a ByteStr) -> Self {
         ByteString(s.0.to_vec())
@@ -642,7 +639,7 @@ impl From<Box<ByteStr>> for Box<[u8]> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(not(no_rc))]
 impl From<Rc<[u8]>> for Rc<ByteStr> {
-    /// Create a `Rc<[u8]>` from `Rc<ByteStr>`s raw.
+    /// Create an `Rc<[u8]>` from the inner bytes of `Rc<ByteStr>`.
     #[inline]
     fn from(s: Rc<[u8]>) -> Rc<ByteStr> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -653,7 +650,7 @@ impl From<Rc<[u8]>> for Rc<ByteStr> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(not(no_rc))]
 impl From<Rc<ByteStr>> for Rc<[u8]> {
-    /// Create a `Rc<ByteStr>` from `Rc<[u8]>`s raw.
+    /// Create a `Rc<ByteStr>` from the bytes of `Rc<[u8]>`.
     #[inline]
     fn from(s: Rc<ByteStr>) -> Rc<[u8]> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -664,7 +661,7 @@ impl From<Rc<ByteStr>> for Rc<[u8]> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))]
 impl From<Arc<[u8]>> for Arc<ByteStr> {
-    /// Create a `Arc<ByteStr>` from `Arc<[u8]>`s raw.
+    /// Create an `Arc<ByteStr>` from the bytes of `Arc<[u8]>`.
     #[inline]
     fn from(s: Arc<[u8]>) -> Arc<ByteStr> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.
@@ -675,7 +672,8 @@ impl From<Arc<[u8]>> for Arc<ByteStr> {
 #[unstable(feature = "bstr", issue = "134915")]
 #[cfg(all(not(no_rc), not(no_sync), target_has_atomic = "ptr"))]
 impl From<Arc<ByteStr>> for Arc<[u8]> {
-    /// Create a `Arc<ByteStr>` from `Arc<[u8]>`s raw.
+    /// Create a `Arc<[u8]>` from the inner bytes of `Arc<ByteStr>`.
+    
     #[inline]
     fn from(s: Arc<ByteStr>) -> Arc<[u8]> {
         // SAFETY: `ByteStr` is a transparent wrapper around `[u8]`.

library/alloc/src/task.rs

@@ -107,10 +107,7 @@ pub trait Wake {
 #[cfg(target_has_atomic = "ptr")]
 #[stable(feature = "wake_trait", since = "1.51.0")]
 impl<W: Wake + Send + Sync + 'static> From<Arc<W>> for Waker {
-    /// Use a [`Wake`]-able type as a `Waker`.
-    ///
-    /// ## Cost
-    /// No heap allocations or atomic operations are used for this conversion.
+    /// Use a [`Wake`]-able type as a `Waker`. Without any heap allocations or atomic operations.
     fn from(waker: Arc<W>) -> Waker {
         // SAFETY: This is safe because raw_waker safely constructs
         // a RawWaker from Arc<W>.
@@ -120,10 +117,7 @@ impl<W: Wake + Send + Sync + 'static> From<Arc<W>> for Waker {
 #[cfg(target_has_atomic = "ptr")]
 #[stable(feature = "wake_trait", since = "1.51.0")]
 impl<W: Wake + Send + Sync + 'static> From<Arc<W>> for RawWaker {
-    /// Use a `Wake`-able type as a `RawWaker`.
-    ///
-    /// ## Cost
-    /// No heap allocations or atomic operations are used for this conversion.
+    /// Use a `Wake`-able type as a `RawWaker`. Without any heap allocations or atomic operations.
     fn from(waker: Arc<W>) -> RawWaker {
         raw_waker(waker)
     }
@@ -288,10 +282,7 @@ pub trait LocalWake {
 
 #[unstable(feature = "local_waker", issue = "118959")]
 impl<W: LocalWake + 'static> From<Rc<W>> for LocalWaker {
-    /// Use a `Wake`-able type as a `LocalWaker`.
-    ///
-    /// ## Cost
-    /// No heap allocations or atomic operations are used for this conversion.
+    /// Use a `Wake`-able type as a `LocalWaker`. Without any heap allocations or atomic operations.
     fn from(waker: Rc<W>) -> LocalWaker {
         // SAFETY: This is safe because raw_waker safely constructs
         // a RawWaker from Rc<W>.
@@ -301,10 +292,7 @@ impl<W: LocalWake + 'static> From<Rc<W>> for LocalWaker {
 #[allow(ineffective_unstable_trait_impl)]
 #[unstable(feature = "local_waker", issue = "118959")]
 impl<W: LocalWake + 'static> From<Rc<W>> for RawWaker {
-    /// Use a `Wake`-able type as a `RawWaker`.
-    ///
-    /// ## Cost
-    /// No heap allocations or atomic operations are used for this conversion.
+    /// Use a `Wake`-able type as a `RawWaker`. Without any heap allocations or atomic operations.
     fn from(waker: Rc<W>) -> RawWaker {
         local_raw_waker(waker)
     }

library/std/src/sys/fs/windows.rs

@@ -1057,8 +1057,7 @@ impl FileAttr {
     }
 }
 impl From<c::WIN32_FIND_DATAW> for FileAttr {
-    /// Map `c::WIN32_FIND_DATAW`s fields to a `FileAttr`,
-    /// with some conditionals for `file_size` and `reparse_tag`.
+    /// Map `c::WIN32_FIND_DATAW`s fields to a `FileAttr`.
     fn from(wfd: c::WIN32_FIND_DATAW) -> Self {
         FileAttr {
             attributes: wfd.dwFileAttributes,

src/tools/miri/src/concurrency/vector_clock.rs

@@ -34,7 +34,7 @@ impl Idx for VectorIdx {
 }
 
 impl From<u32> for VectorIdx {
-    /// Create new `VectorIdx` with `u32` as inner.
+    /// Create new `VectorIdx` with the inner id of `u32`.
     #[inline]
     fn from(id: u32) -> Self {
         Self(id)

src/tools/miri/src/shims/io_error.rs

@@ -14,7 +14,6 @@ pub enum IoError {
 pub use self::IoError::*;
 
 impl From<io::Error> for IoError {
-    /// Wrap `io::Error` in `HostError`.
     fn from(value: io::Error) -> Self {
         IoError::HostError(value)
     }
@@ -28,7 +27,7 @@ impl From<io::ErrorKind> for IoError {
 }
 
 impl From<Scalar> for IoError {
-    /// Wrap `Scalar` in `Raw`.
+    /// Create a `Raw` `IoError` with a `Scalar`.
     fn from(value: Scalar) -> Self {
         IoError::Raw(value)
     }