add appropriate

Author: Kohei316

compiler/rustc_hir_typeck/src/method/suggest.rs

@@ -3337,11 +3337,15 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                 //     trait_did,
                 //     with_crate_prefix!(self.tcx.def_path_str(*trait_did))
                 // );
+                // format!(
+                //     "{prefix}{}{postfix}\n",
+                //     with_no_visible_paths_if_doc_hidden!(with_crate_prefix!(
+                //         self.tcx.def_path_str(*trait_did)
+                //     )),
+                // )
                 format!(
                     "{prefix}{}{postfix}\n",
-                    with_no_visible_paths_if_doc_hidden!(with_crate_prefix!(
-                        self.tcx.def_path_str(*trait_did)
-                    )),
+                    with_crate_prefix!(self.tcx.def_path_str(*trait_did)),
                 )
             });
 

compiler/rustc_middle/src/ty/print/pretty.rs

@@ -493,9 +493,6 @@ pub trait PrettyPrinter<'tcx>: Printer<'tcx> + fmt::Write {
         callers: &mut Vec<DefId>,
     ) -> Result<bool, PrintError> {
         // debug!("try_print_visible_def_path: def_id={:?}", def_id);
-        if self.tcx().is_doc_hidden(def_id) && with_no_visible_paths_if_doc_hidden() {
-            return Ok(false);
-        }
 
         // If `def_id` is a direct or injected extern crate, return the
         // path to the crate followed by the path to the item within the crate.
@@ -577,6 +574,10 @@ pub trait PrettyPrinter<'tcx>: Printer<'tcx> + fmt::Write {
             return Ok(false);
         };
 
+        if self.tcx().is_doc_hidden(visible_parent) && with_no_visible_paths_if_doc_hidden() {
+            return Ok(false);
+        }
+
         let actual_parent = self.tcx().opt_parent(def_id);
         // debug!(
         //     "try_print_visible_def_path: visible_parent={:?} actual_parent={:?}",

tests/ui/typeck/auxiliary/suggest-trait-reexported-as-not-doc-visible-a.rs

@@ -0,0 +1,5 @@
+//@ edition: 2021
+
+pub trait Foo {
+    fn foo();
+}

tests/ui/typeck/auxiliary/suggest-trait-reexported-as-not-doc-visible-b.rs

@@ -0,0 +1,13 @@
+//@ edition: 2021
+//@ aux-crate:suggest_trait_reexported_as_not_doc_visible_a=suggest-trait-reexported-as-not-doc-visible-a.rs
+
+pub struct Bar;
+
+impl __DocHidden::Foo for Bar {
+    fn foo() {}
+}
+
+#[doc(hidden)]
+pub mod __DocHidden {
+    pub use suggest_trait_reexported_as_not_doc_visible_a::Foo;
+}

tests/ui/typeck/suggest-trait-reexported-as-not-doc-visible.rs

@@ -0,0 +1,10 @@
+//@ edition: 2021
+//@ aux-crate:suggest_trait_reexported_as_not_doc_visible_a=suggest-trait-reexported-as-not-doc-visible-a.rs
+//@ aux-crate:suggest_trait_reexported_as_not_doc_visible_b=suggest-trait-reexported-as-not-doc-visible-b.rs
+
+use suggest_trait_reexported_as_not_doc_visible_b::Bar;
+
+fn main() {
+    Bar::foo();
+    //~^ ERROR: no function or associated item named `foo` found for struct `Bar` in the current scope [E0599]
+}

tests/ui/typeck/suggest-trait-reexported-as-not-doc-visible.stderr

@@ -0,0 +1,15 @@
+error[E0599]: no function or associated item named `foo` found for struct `Bar` in the current scope
+  --> $DIR/suggest-trait-reexported-as-not-doc-visible.rs:8:10
+   |
+LL |     Bar::foo();
+   |          ^^^ function or associated item not found in `Bar`
+   |
+   = help: items from traits can only be used if the trait is in scope
+help: trait `Foo` which provides `foo` is implemented but not in scope; perhaps you want to import it
+   |
+LL + use suggest_trait_reexported_as_not_doc_visible_b::__DocHidden::Foo;
+   |
+
+error: aborting due to 1 previous error
+
+For more information about this error, try `rustc --explain E0599`.