Rollup of 7 pull requests #100151
Merged
Rollup of 7 pull requests #100151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a result of https://reviews.llvm.org/D130592.
…=estebank Do not exclusively suggest `;` when `,` is also a choice Fixes rust-lang#96791
…=Mark-Simulacrum Re-enable submodule archive downloads. This is effectively a revert of rust-lang#98423 (though it keeps the `--depth 1` flag since that is still helpful). GitHub has indicated that they have been working on the original issue, and my testing shows that the llvm-project archive download now succeeds 100% of the time. This should save about a minute on every job.
…ing-argument-instead-of-format-args-capture, r=estebank Suggest a positional formatting argument instead of a captured argument This patch fixes a part of rust-lang#96999. fixes rust-lang#98241 fixes rust-lang#97311 r? `@estebank`
…tch-arms, r=petrochenkov Enable unused_parens for match arms Fixes: rust-lang#92751 Currently I can't get the `stderr` to work with `./x.py test`, but this should fix the issue. Help would be appreciated!
More EarlyBinder cleanups Each commit is independent r? types
…otriddle Remove more Clean trait implementations Follow-up of rust-lang#99638. r? `@notriddle`
RustWrapper: update for TypedPointerType in LLVM This is a result of https://reviews.llvm.org/D130592. r? `@nikic`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (f6f9d5e): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
;when,is also a choice #98796 (Do not exclusively suggest;when,is also a choice)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup