Skip to content

Improvements to dataflow const-prop #115612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Improvements to dataflow const-prop #115612

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d35be6c
Do not assert in try_to_int.
cjgillot Jan 18, 2023
09ce0f6
Remove type from ScalarTy.
cjgillot Sep 5, 2023
7ef555d
Support non-trivial scalars in ConstProp.
cjgillot May 12, 2023
74a967b
Support a few more rvalues.
cjgillot Apr 15, 2023
22986b7
Implement algebraic simplifications.
cjgillot Apr 15, 2023
fc63543
Support array length.
cjgillot Apr 23, 2023
f96c6e0
Propagate PlaceElem::Index.
cjgillot Apr 23, 2023
4ad22b9
Correct comment and assumption.
cjgillot Sep 7, 2023
b7a925a
Add test where slice is a const.
cjgillot Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_middle/src/mir/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2317,7 +2317,7 @@ impl<'tcx> ConstantKind<'tcx> {

#[inline]
pub fn try_to_scalar_int(self) -> Option<ScalarInt> {
Some(self.try_to_scalar()?.assert_int())
self.try_to_scalar()?.try_to_int().ok()
}
Comment on lines 2326 to 2328
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we did this on purpose, but since it's undocumented and a footgun 👍


#[inline]
Expand Down