Skip to content

Store #[stable] attribute's since value in structured form #117148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Store #[stable] attribute's since value in structured form #117148

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2ae7b5
Store 'since' attribute as parsed Version
dtolnay Oct 24, 2023
ddcb183
Keep track of #[stable] attribute even if version cannot be parsed
dtolnay Oct 24, 2023
7b0e315
Update stability attribute sanity UI test to delete superfluous errors
dtolnay Oct 24, 2023
6933a67
Handle structured stable attribute 'since' version in rustdoc
dtolnay Oct 24, 2023
fd8907f
Handle structured stable attribute 'since' version in clippy
dtolnay Oct 25, 2023
51f7fba
CFG_RELEASE is mandatory, no need for option_env
dtolnay Oct 25, 2023
1a9ea1f
Expose a non-Symbol way to access current rustc version string
dtolnay Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions compiler/rustc_attr/src/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ use crate::session_diagnostics::{self, IncorrectReprFormatGenericCause};
pub const VERSION_PLACEHOLDER: &str = "CURRENT_RUSTC_VERSION";

pub fn rust_version_symbol() -> Symbol {
let version = option_env!("CFG_RELEASE").unwrap_or("<current>");
Symbol::intern(&version)
Symbol::intern(env!("CFG_RELEASE"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in rustc_span::symbol, to avoid reinterning this symbol multiple times?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll take care of that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#117188

}

pub fn is_builtin_attr(attr: &Attribute) -> bool {
Expand Down