Skip to content

Return opaque type from PanicInfo::message() #126330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

Return opaque type from PanicInfo::message() #126330

merged 1 commit into from
Jun 18, 2024

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jun 12, 2024

This changes the return type of the (unstable) PanicInfo::message() method to an opaque type (that implements Display). This allows for a bit more flexibility in the future.

See #66745

@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 12, 2024
@m-ou-se m-ou-se mentioned this pull request Jun 12, 2024
Closed
9 tasks
@m-ou-se m-ou-se force-pushed the panic-message-type branch from 9fb1234 to 730f17e Compare June 12, 2024 13:44
StackOverflowExcept1on
StackOverflowExcept1on reviewed Jun 12, 2024
View reviewed changes
@bors
Copy link
Collaborator

bors commented Jun 12, 2024

☔ The latest upstream changes (presumably #126332) made this pull request unmergeable. Please resolve the merge conflicts.

@Amanieu
Copy link
Member

Amanieu commented Jun 14, 2024

r=me once conflicts are resolved

@Amanieu Amanieu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024
@m-ou-se m-ou-se force-pushed the panic-message-type branch from 730f17e to 6c2507c Compare June 17, 2024 18:45
@m-ou-se
Copy link
Member Author

m-ou-se commented Jun 18, 2024

@bors r=Amanieu

@bors
Copy link
Collaborator

bors commented Jun 18, 2024

📌 Commit 6c2507c has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2024
@bors
Copy link
Collaborator

bors commented Jun 18, 2024

⌛ Testing commit 6c2507c with merge f873ae0...

@bors
Copy link
Collaborator

bors commented Jun 18, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing f873ae0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 18, 2024
@bors bors merged commit f873ae0 into rust-lang:master Jun 18, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 18, 2024
@m-ou-se m-ou-se deleted the panic-message-type branch June 18, 2024 13:43
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f873ae0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results (secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 11
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 670.264s -> 670.725s (0.07%)
Artifact size: 320.46 MiB -> 320.46 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@StackOverflowExcept1on StackOverflowExcept1on StackOverflowExcept1on left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Amanieu Amanieu

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Milestone

1.81.0