Do not allow safe/unsafe on static and fn items

[spastorino]

Fixes #126749

r? @compiler-errors

Tracking:

• Tracking Issue for RFC 3484: Unsafe Extern Blocks #123743

[compiler-errors]

This doesn't gate safe on cfg'd out code, so this still passes:

#[cfg(FALSE)]
safe fn foo() {}

I'm not sure if that was intentional, since I thought you intended to put this up as an alternative to #126757. If that's not the case, then you can ignore this.

This also doesn't consider other positions where safety may show up, like:

• Impl items and trait items
• Function pointers

[compiler-errors]

edited my review comment a bit since i'm not sure what the relationship between #126757 and this PR is supposed to be.

[spastorino]

@rustbot ready

[compiler-errors]

@bors r+ rollup

[bors]

📌 Commit 3d6d9e2 has been approved by compiler-errors

It is now in the queue for this repository.

[spastorino]

@bors r=compiler-errors

[bors]

📌 Commit 22831ed has been approved by compiler-errors

It is now in the queue for this repository.

[ytmimi]

@compiler-errors @spastorino is this going to cause issues with https://github.com/rust-lang/rustfmt/pull/6204/files#r1648395270? Specifically I'm wondering about the test case that uses safe on the static TEST1 item.

[compiler-errors]

No -- this is validation that only happens when you try to compile the code.

[ytmimi]

Awesome. Thanks for the quick response. Just wanted to make sure that this wouldn't cause issues for the upcoming sync

[bors]

⌛ Testing commit 22831ed with merge 9cf721a...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  SDKROOT: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk
  AR: ar
##[endgroup]
curl: (28) Operation too slow. Less than 100 bytes/sec transferred the last 5 seconds
Error: Failure while executing; `/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --user-agent Homebrew/4.3.5\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.6.7\)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --remote-time --output /Users/runner/Library/Caches/Homebrew/api/cask.jws.json --location --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.3.5\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.6.7\)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --compressed --speed-limit 100 --speed-time 5 https://formulae.brew.sh/api/cask.jws.json` exited with 28. Here's the output:


##[error]Failure while executing; `/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --user-agent Homebrew/4.3.5\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.6.7\)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --remote-time --output /Users/runner/Library/Caches/Homebrew/api/cask.jws.json --location --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.3.5\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.6.7\)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --compressed --speed-limit 100 --speed-time 5 https://formulae.brew.sh/api/cask.jws.json` exited with 28. Here's the output:
##[error]Process completed with exit code 1.
Post job cleanup.
[command]/usr/local/bin/git version
git version 2.45.2

[compiler-errors]

@bors retry

[bors]

⌛ Testing commit 22831ed with merge fcae626...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing fcae626 to master...

[rust-timer]

Finished benchmarking commit (fcae626): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.3%	[-4.3%, -4.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.3%	[-4.3%, -4.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 697.477s -> 693.147s (-0.62%)
Artifact size: 326.87 MiB -> 326.88 MiB (0.00%)