Skip to content

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Oct 17, 2024

The main change is to fix segfaults on 32-bit FreeBSD targets.

Fixes #130677

The main change is to fix segfaults on 32-bit FreeBSD targets.

Fixes rust-lang#130677
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 17, 2024
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.944 Building wheels for collected packages: reuse
#13 2.945   Building wheel for reuse (pyproject.toml): started
#13 3.205   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.206   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#13 3.206   Stored in directory: /tmp/pip-ephem-wheel-cache-uqkz4n07/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.209 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.621 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.622 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.201 Collecting virtualenv
#13 4.201 Collecting virtualenv
#13 4.251   Downloading virtualenv-20.26.6-py3-none-any.whl (6.0 MB)
#13 4.442      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 6.0/6.0 MB 31.7 MB/s eta 0:00:00
#13 4.506 Collecting filelock<4,>=3.12.2
#13 4.514   Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.537 Collecting distlib<1,>=0.3.7
#13 4.546   Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#13 4.557      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 55.6 MB/s eta 0:00:00
#13 4.595 Collecting platformdirs<5,>=3.9.1
#13 4.603   Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.688 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.892 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.26.6
#13 DONE 5.0s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      206784 kB
DirectMap2M:     7133184 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2024-10-16/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
---
##[endgroup]
fmt check
fmt: checked 5608 files
tidy check
thread 'deps (.)' panicked at src/tools/tidy/src/deps.rs:599:24:
cmd.exec() failed with `cargo metadata` exited with an error:     Updating crates.io index
error: the lock file /checkout/library/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at src/tools/tidy/src/main.rs:60:49:
called `Result::unwrap()` on an `Err` value: Any { .. }
called `Result::unwrap()` on an `Err` value: Any { .. }
Command has failed. Rerun with -v to see more details.
  local time: Thu Oct 17 21:26:47 UTC 2024
  network time: Thu, 17 Oct 2024 21:26:48 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@workingjubilee
Copy link
Member

Thank you!

Unfortunately duplicates #131823 SO!

@asomers asomers deleted the libc-0.2.161 branch October 17, 2024 21:37
@asomers
Copy link
Contributor Author

asomers commented Oct 17, 2024

Ahh, good work . Sorry for missing that other PR, @workingjubilee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SIGSEGV with beta/nightly compiler with i686-unknown-freebsd target

5 participants