DO NOT MERGE: Replace overflowing sub with checked_sub. #134361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case when a no-break-space \u{a0} exists before any non
white space characters an error is generated that points into
the white space. When the terminal width is also too small a
subtraction is triggered here that would overflow. That
subtraction implicitly assumed that no errors occur in the
white space. This commit replaces that subtraction with an
explicitly checked one to avoid this overflow.
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
harrisonkaiser
changed the title
Author
|
Upon further examination, this is the wrong solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case when a no-break-space \u{a0} exists before any non white space characters an error is generated that points into the white space. When the terminal width is also too small a subtraction is triggered here that would overflow. That subtraction implicitly assumed that no errors occur in the white space. This commit replaces that subtraction with an explicitly checked one to avoid this overflow.
Addresses: #132918