Skip to content

Use #[derive(Default)] instead of manual impl when possible #134363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

Use #[derive(Default)] instead of manual impl when possible #134363

merged 1 commit into from
Dec 23, 2024

Conversation

estebank
Copy link
Contributor

While working on #134175 I noticed a few manual Default impls that could be derived instead. These likely predate the existence of the #[default] attribute for enums.

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2024

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2024

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

ytmimi
ytmimi reviewed Dec 16, 2024
View reviewed changes
src/tools/rustfmt/src/config/options.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to open a PR in https://github.com/rust-lang/rustfmt for these changes?

SparrowLii
SparrowLii reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@SparrowLii SparrowLii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are nice clean ups!

@bors
Copy link
Collaborator

bors commented Dec 18, 2024

☔ The latest upstream changes (presumably #134243) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank estebank force-pushed the derive-default branch 2 times, most recently from 636926b to a64347c Compare December 21, 2024 20:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
SparrowLii
SparrowLii approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@SparrowLii SparrowLii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits should be cleaned.
Please r=me after that

@SparrowLii
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 23, 2024

📌 Commit 1f82b45 has been approved by SparrowLii

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 23, 2024
Merged
@bors bors merged commit 95c33e3 into rust-lang:master Dec 23, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi left review comments

@SparrowLii SparrowLii SparrowLii approved these changes

Assignees

@SparrowLii SparrowLii

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Milestone
1.85.0