Arbitrary self types v2: diagnostics in resolution. #134384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we get past all the earlier stages of validation (in well-formedness checking and in probing) there's still a chance that resolving the self type will produce errors at the 'confirmation' stage. Add an extra note to those errors to make it clear that they were encountered while resolving the 'self' type. This is a fairly niche case and users may not encounter it often. It's arguably not worth the extra complexity required to produce this note. Opinions welcome.
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Dec 16, 2024
Member
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Yeah, I don't think this is really worth the extra overhead, especially when all it does is add a note that I think is equally as confusing to the end user.
Contributor
Author
|
Sounds good - thanks. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get past all the earlier stages of validation (in well-formedness checking and in probing) there's still a chance that resolving the self type will produce errors at the 'confirmation' stage. Add an extra note to those errors to make it clear that they were encountered while resolving the 'self' type.
This is a fairly niche case and users should not encounter it often. It's arguably not worth the extra complexity required to produce this note. Opinions welcome.
Part of #44874
r? @wesleywiser