Skip to content

Conversation

@marcoieni
Copy link
Member

@marcoieni marcoieni commented Dec 17, 2024

ubuntu-20 will be removed in April. See announcement here.

How can we test this before merging?
Also, this change will make rust-analyzer incompatible with ubuntu 20 and other old distros, right?

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2024
@marcoieni
Copy link
Member Author

marcoieni commented Dec 17, 2024

Wait..I found this file is duplicated in https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/release.yaml

Maybe I should edit that one?

I'm confused. Why isn't src/tools/rust-analyzer a submodule?

@marcoieni
Copy link
Member Author

anyway, I'll close this

@marcoieni marcoieni closed this Dec 17, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Dec 17, 2024

@marcoieni r-a and miri uses josh, and uses josh to manage josh-mediated subtree syncs (not submodule) IIRC. Note that they're also not purely git subtrees.

Other tools like rustfmt and cargo and custom cg like cg_gcc or cg_clif still use git submodules, IIRC.

e.g. see discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants