Skip to content

fix: multiple typos of different importance #134533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crStiv wants to merge 4 commits into from
Closed

fix: multiple typos of different importance #134533

crStiv wants to merge 4 commits into from

Conversation

@crStiv
Copy link

@crStiv crStiv commented Dec 19, 2024

Description

This pull request addresses several minor and major typographical errors identified in the codebase and documentation. Changes include:

  • Corrections in .github/workflows/ci.yml to fix grammatical issues.
  • Updates to LICENSES/GPL-2.0-only.txt and LICENSES/GPL-3.0-or-later.txt to ensure proper usage of terms like "accord" versus "in accordance".
  • Fixes in compiler/rustc_arena/src/lib.rs to resolve word choice errors, such as replacing "similarlty" with "similarity."

These changes improve the clarity and professionalism of the project without affecting functionality or logic.

Comments

  • This PR resolves inconsistencies but does not involve any tracked unstable features or other critical efforts.
  • Assigned reviewers can be modified by maintainers if necessary.
  • Ready for review.

Allow Edits

✅ Maintainers can make direct edits to this PR.

This submission ensures alignment with the repository's contribution guidelines, security policy, and code of conduct.

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kobzol (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2024
@lqd
Copy link
Member

lqd commented Dec 19, 2024

Please remove the incorrect changes from the license files, and squash the commits.

jieyouxu
jieyouxu requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you drop the LICENSES/ changes and squash the comments (as lqd mentioned above), we can merge this.

LICENSES/GPL-2.0-only.txt
Copy link
Member

@jieyouxu jieyouxu Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: please do not change things under LICENSES/.

@jieyouxu
Copy link
Member

jieyouxu commented Dec 19, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2024
bjorn3
bjorn3 reviewed Dec 19, 2024
View reviewed changes
LICENSES/GPL-2.0-only.txt

a) Accompany it with the complete corresponding machine-readable source code, which must be distributed under the terms of Sections 1 and 2 above on a medium customarily used for software interchange; or,
b) Accompany it with a written offer, valid for at least three years, to give any third party, for a charge no more than your cost of physically performing source distribution, a complete machine-readable copy of the corresponding source code, to be distributed under the terms of Sections 1 and 2 above on a medium customarily used for software interchange; or,
c) Accompany it with the information you received as to the offer to distribute corresponding source code. (This alternative is allowed only for noncommercial distribution and only if you received the program in object code or executable form with such an offer, in accord with Subsection b above.)
Copy link
Member

@bjorn3 bjorn3 Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the fact that modifying the license is a copyright violation (

Everyone is permitted to copy and distribute verbatim copies
of this license document, but changing it is not allowed.

) and that it could be considered a relicensing (which needs agreement from everyone which contributed code under said license, disclaimer: IANAL), "in accord with" is actually valid English: https://dictionary.cambridge.org/dictionary/english/in-accord-with

@crStiv
Copy link
Author

crStiv commented Dec 19, 2024 •
edited
Loading

@jieyouxu @bjorn3 May I just close this PR and open the new one with all the changes included?

@lqd
Copy link
Member

lqd commented Dec 19, 2024

No need for a new PR, this one will be fine once it's fixed.

@crStiv
Copy link
Author

crStiv commented Dec 19, 2024

@lqd @bjorn3 @jieyouxu I'm using GitHub via browser and I didn't find a way to make changes in PR, so I'm gonna create a new PR with one more typo being found, and I'll close this PR. Hope you'll understand me

@crStiv crStiv closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@jieyouxu jieyouxu jieyouxu requested changes

Assignees

@Kobzol Kobzol

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crStiv @rustbot @lqd @jieyouxu @bjorn3 @Kobzol