Skip to content

Remove the need to update build-gccjit.sh script every time GCC backend do a sync #135490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove the need to update build-gccjit.sh script every time GCC backend do a sync #135490

wants to merge 1 commit into from

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 14, 2025

Last sync we lost some time remembering we needed to update build-gccjit.sh. I don't think there is any reason to not copy the file inside the Dockerfile so here it is.

cc @antoyo
r? @Kobzol

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 14, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 14, 2025

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Kobzol
Copy link
Member

Kobzol commented Jan 14, 2025

Hmm, I wonder how this will interact with Docker caching. Actually, I have a PR mostly ready that builds GCC from tree, after which we could remove build-gccjit.sh altogether, I hope.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 14, 2025

😮 That's much better than this hack!
Then let's close this.

@GuillaumeGomez GuillaumeGomez deleted the gcc-backend-sync branch January 14, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @rust-log-analyzer @Kobzol @rustbot