restrict pub to crate

[hkBst]

No description provided.

[rustbot]

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[compiler-errors]

This seems inconsistent at best, and slight code churn at worst. Thanks for the contribution! but I don't think it provides much value, so I gonna go ahead and close it :)

[hkBst]

@compiler-errors At the time, I thought I could use this change to test whether this enum was used outside this crate. I've since realised that does not work because the enum itself is also exported. However it does show that the variant names aren't used without qualification by the enum name. The inconsistency can be fixed by changing the other enums to also not publically export their variants. I don't think you would disagree that there is a small code smell here. I should probably have made this PR a draft, but maybe you closed this too quickly?