Skip to content

Conversation

@compiler-errors
Copy link
Member

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 24, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
…gions, r=<try>

Rewrite `normalize_erasing_regions` to not use `QueryNormalizer`

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Jan 24, 2025

⌛ Trying commit 6d70fcc with merge 8c6c13e...

@bors
Copy link
Collaborator

bors commented Jan 24, 2025

☀️ Try build successful - checks-actions
Build commit: 8c6c13e (8c6c13e492feebaa44665a6575e08ec88157f9da)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8c6c13e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.5% [0.2%, 2.1%] 23
Regressions ❌
(secondary)
2.6% [0.3%, 9.3%] 31
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-7.9% [-8.3%, -7.6%] 3
All ❌✅ (primary) 0.5% [0.2%, 2.1%] 23

Max RSS (memory usage)

Results (primary -1.1%, secondary -1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)
2.6% [2.0%, 3.1%] 2
Improvements ✅
(primary)
-2.2% [-6.1%, -0.7%] 4
Improvements ✅
(secondary)
-3.5% [-6.3%, -2.1%] 4
All ❌✅ (primary) -1.1% [-6.1%, 3.5%] 5

Cycles

Results (primary 1.3%, secondary 1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.0%, 1.6%] 4
Regressions ❌
(secondary)
3.4% [2.0%, 8.8%] 17
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.4% [-6.7%, -6.2%] 3
All ❌✅ (primary) 1.3% [1.0%, 1.6%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.487s -> 777.739s (0.42%)
Artifact size: 326.07 MiB -> 326.01 MiB (-0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 24, 2025
@compiler-errors compiler-errors force-pushed the normalize-erasing-regions branch from 6d70fcc to 485c6f4 Compare January 25, 2025 05:35
@rustbot rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Jan 25, 2025
@compiler-errors compiler-errors force-pushed the normalize-erasing-regions branch from 485c6f4 to 6d70fcc Compare January 25, 2025 05:36
@compiler-errors compiler-errors force-pushed the normalize-erasing-regions branch from 6d70fcc to 2080614 Compare January 27, 2025 20:37
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 27, 2025
@bors
Copy link
Collaborator

bors commented Jan 27, 2025

⌛ Trying commit 2080614 with merge ea514dc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
…gions, r=<try>

Rewrite `normalize_erasing_regions` to not use `QueryNormalizer`

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Jan 27, 2025

☀️ Try build successful - checks-actions
Build commit: ea514dc (ea514dc0ea8a12aaf062ca1fbdfbe89e9b825b0e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ea514dc): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.5% [0.2%, 0.7%] 18
Regressions ❌
(secondary)
2.7% [0.6%, 9.6%] 27
Improvements ✅
(primary)
-0.2% [-0.2%, -0.2%] 2
Improvements ✅
(secondary)
-5.2% [-7.5%, -1.0%] 3
All ❌✅ (primary) 0.4% [-0.2%, 0.7%] 20

Max RSS (memory usage)

Results (primary -0.7%, secondary -1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)
2.9% [2.2%, 3.6%] 2
Improvements ✅
(primary)
-1.0% [-1.8%, -0.6%] 4
Improvements ✅
(secondary)
-3.8% [-7.0%, -1.1%] 4
All ❌✅ (primary) -0.7% [-1.8%, 0.8%] 5

Cycles

Results (primary 0.8%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)
4.3% [2.1%, 10.3%] 24
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.7% [-7.8%, -1.8%] 4
All ❌✅ (primary) 0.8% [0.8%, 0.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.391s -> 775.702s (0.17%)
Artifact size: 328.16 MiB -> 328.13 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 28, 2025
@compiler-errors
Copy link
Member Author

will need to wait for next solver i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants