Skip to content

[EXPERIMENTAL] Crater run for impact of making unit_bindings warn-by-default #136880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu wants to merge 1 commit into from
Closed

[EXPERIMENTAL] Crater run for impact of making unit_bindings warn-by-default #136880

jieyouxu wants to merge 1 commit into from

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Feb 11, 2025 •
edited
Loading

Wanted to gauge how many crates this may affect.

Note for myself: crater command should be

@\craterbot check start=master#XXX end=try#XXX+rustflags=-Dunit_bindings

r? @ghost

@jieyouxu jieyouxu added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Feb 11, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2025
@jieyouxu jieyouxu added L-unit_bindings Lint: unit_bindings and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Feb 11, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2025
@bors
Auto merge of rust-lang#136880 - jieyouxu:crater-unit-bindings, r=<try>
5b5b42e 
[EXPERIMENTAL] Crater run for impact of making `unit_bindings` warn-by-default

Wanted to gauge how many crates this may affect.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Feb 11, 2025

⌛ Trying commit 4f5311d with merge 5b5b42e...

@jieyouxu
Copy link
Member Author

jieyouxu commented Feb 11, 2025

I realized (and was reminded) that I can just use latest master. Oops.

@jieyouxu jieyouxu closed this Feb 11, 2025
@jieyouxu jieyouxu deleted the crater-unit-bindings branch February 11, 2025 18:49
@jieyouxu jieyouxu removed the L-unit_bindings Lint: unit_bindings label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jieyouxu @bors @rustbot