Skip to content

Tweak comma handling of "missing match arm" suggestion and fix "remove this arm" suggestion, and make suggestion verbose #137409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Tweak comma handling of "missing match arm" suggestion and fix "remove this arm" suggestion, and make suggestion verbose #137409

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d45d1e
Tweak "add match arm" suggestion
estebank Feb 22, 2025
49e776a
Fix incorrect suggestion for never patterns with bodies or guard
estebank Feb 22, 2025
049e437
fix clippy tests
estebank Feb 22, 2025
78289ff
Account for non-exhausitve match expression coming from macro expansion
estebank Feb 25, 2025
ced1fe9
When lowering paren surrounded pattern, keep outer span
estebank Feb 25, 2025
00150b7
Fallback removal span when involving macros
estebank Feb 26, 2025
3c26d34
fix rebase
estebank Mar 1, 2025
7e1f8f2
Make never pattern suggestions hidden
estebank Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/ui/never_type/unused_trait_in_never_pattern_body.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,18 @@ LL | |
LL | | use std::ops::Add;
LL | | 0.add(1)
LL | | },
| | ^
| | |
| |_________this will never be executed
| help: remove this expression
| |_________^ this will never be executed
|
help: remove the match arm expression
|
LL - ! => || {
LL -
LL -
LL - use std::ops::Add;
LL - 0.add(1)
LL - },
LL + !,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of lines, to the point that it's a bit hard to even see (without coloration) that this is even suggesting to leave the plain ! and remove everything else. we should probably make this suggestion hidden?

|

error: mismatched types
--> $DIR/unused_trait_in_never_pattern_body.rs:3:9
Expand Down
Loading