Skip to content

Various coretests improvements #137679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Various coretests improvements #137679

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b60aeb0
Stop passing --lib to cargo test
bjorn3 Feb 26, 2025
b491494
Also test coretests when running ./x.py test core
bjorn3 Feb 19, 2025
169e731
Fix unused import in coretests on wasm32
bjorn3 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/bootstrap/src/core/build_steps/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2785,14 +2785,15 @@ impl Step for Crate {
_ => panic!("can only test libraries"),
};

run_cargo_test(
cargo,
&[],
&self.crates,
&*crate_description(&self.crates),
target,
builder,
);
let mut crates = self.crates.clone();
// The core crate can't directly be tested. We could silently
// ignore it, but adding it's own test crate is less confusing
// for users. We still keep core itself for doctests.
if crates.iter().any(|crate_| crate_ == "core") {
crates.push("coretests".to_owned());
}
Comment on lines +2788 to +2794
Copy link
Member

@jieyouxu jieyouxu Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this here feels somewhat iffy to me, but the Crate step is iffy itself (I feel like we really ought to be splitting it to be a library-crate-facing step vs compiler-crate-facing step).


run_cargo_test(cargo, &[], &crates, &*crate_description(&self.crates), target, builder);
}
}

Expand Down