Add unwrap_or_else and msrv to rustc_span::sym #137692
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
Collaborator
|
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in src/tools/cargo cc @ehuss |
Member
Author
|
Oh no, this was supposed to be a small change. I'm very sorry to the people pinged, it was not supposed to happen and I'm working on it :/ |
This comment has been minimized.
This comment has been minimized.
blyxyas
force-pushed
the
more-symbols
branch
from
9639d59 to
d7a7c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple symbols needed for Clippy, we generally batch these in greater quantities, but I just found out that our MSRV system calls to
Symbol::intern("msrv")3-4x more than all other uses ofSymbol::interncombined. So it's definitely needed.