Skip to content

Prevent ICE at codegen_attrs.rs in autodiff validation by emitting nice error message #137906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Prevent ICE at codegen_attrs.rs in autodiff validation by emitting nice error message #137906

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b29bb6
Prevent ICE in autodiff validation by emitting user-friendly errors
Sa4dUs Mar 2, 2025
465e696
Fix ICE for invalid return activity and proper error handling
Sa4dUs Mar 7, 2025
070d517
Fix ICE for invalid return activity and proper error handling
Sa4dUs Mar 7, 2025
36e0433
Fix merge conflicts
Sa4dUs Mar 8, 2025
40713d3
Fix merge conflicts
Sa4dUs Mar 8, 2025
631ebca
Merge branch 'master' of https://github.com/Sa4dUs/rust
Sa4dUs Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions compiler/rustc_codegen_ssa/src/codegen_attrs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,13 +930,19 @@ fn autodiff_attrs(tcx: TyCtxt<'_>, id: DefId) -> Option<AutoDiffAttrs> {
}
}

// Validate input and return activities
let mut msg = "".to_string();
for &input in &arg_activities {
if !valid_input_activity(mode, input) {
span_bug!(attr.span(), "Invalid input activity {} for {} mode", input, mode);
msg = format!("Invalid input activity {} for {} mode", input, mode);
}
}
if !valid_ret_activity(mode, ret_activity) {
span_bug!(attr.span(), "Invalid return activity {} for {} mode", ret_activity, mode);
msg = format!("Invalid return activity {} for {} mode", ret_activity, mode);
}
if msg != "".to_string() {
tcx.dcx().struct_span_err(attr.span(), msg).with_note("invalid activity").emit();
return Some(AutoDiffAttrs::error());
}

Some(AutoDiffAttrs { mode, ret_activity, input_activity: arg_activities })
Expand Down
Loading