Skip to content

ci: fix i686-mingw test coverage #138100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: fix i686-mingw test coverage #138100

wants to merge 1 commit into from

Conversation

@marcoieni
Copy link
Member

@marcoieni marcoieni commented Mar 6, 2025 •
edited
Loading

Raised in Zulip.

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 6, 2025
jieyouxu
jieyouxu reviewed Mar 6, 2025
View reviewed changes
@marcoieni
Copy link
Member Author

marcoieni commented Mar 6, 2025

@bors try

@bors
Copy link
Collaborator

bors commented Mar 6, 2025

⌛ Trying commit 2eb993e with merge b10b56b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2025
@bors
Auto merge of rust-lang#138100 - marcoieni:fix-mingw-tests, r=<try>
b10b56b 
ci: fix i686-mingw test coverage

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
@bors
Copy link
Collaborator

bors commented Mar 6, 2025

☀️ Try build successful - checks-actions
Build commit: b10b56b (b10b56b893088494cfd81ab0cd715b375a3e00b2)

@marcoieni
Copy link
Member Author

marcoieni commented Mar 6, 2025

@bors try

@marcoieni
Copy link
Member Author

marcoieni commented Mar 6, 2025

the third job is too slow
image

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2025
@bors
Auto merge of rust-lang#138100 - marcoieni:fix-mingw-tests, r=<try>
af88c8d 
ci: fix i686-mingw test coverage

try-job: i686-mingw-1
try-job: i686-mingw-2
try-job: i686-mingw-3
@bors
Copy link
Collaborator

bors commented Mar 6, 2025

⌛ Trying commit 2eb993e with merge af88c8d...

@bors
Copy link
Collaborator

bors commented Mar 6, 2025

☀️ Try build successful - checks-actions
Build commit: af88c8d (af88c8d9f26d2e5679f497f44dad986dce31c2e7)

@marcoieni
Copy link
Member Author

marcoieni commented Mar 7, 2025

The third job is still too slow. I'm closing this PR since, as noted on zulip, we are going to remove these tests in one week anyway.

@marcoieni marcoieni closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni @rustbot @bors @jieyouxu @Mark-Simulacrum