Skip to content

Add a tidy check for [lints] workspace = true. #138295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add a tidy check for [lints] workspace = true. #138295

wants to merge 1 commit into from

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Mar 10, 2025 •
edited by jieyouxu
Loading

For compiler/ crates.

Closes #138195.

r? @jieyouxu

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 10, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Mar 10, 2025

Thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 10, 2025

📌 Commit 00c3896 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Mar 10, 2025

Might have some issues with the workspace lint approach cf. #138304.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2025
@nnethercote
Copy link
Contributor Author

nnethercote commented Mar 11, 2025

Yeah, no longer relevant.

@nnethercote nnethercote deleted the tidy-workspace-lints branch May 22, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jieyouxu jieyouxu

Labels

A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a tidy check to enforce that all compiler/*/Cargo.tomlcontains lints.workspace = true

4 participants

@nnethercote @jieyouxu @bors @rustbot